Attention is currently required from: Jérémy Compostella, Shuo Liu, yuchi.chen@intel.com.
Elyes Haouas has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )
Change subject: src/soc/intel/common/block/imc: add Integrated Memory Controller driver
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/imc/imc.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/e6a30c2b_9340d16e?usp... :
PS2, Line 7: #include <arch/mmio.h>
it's ok, but I'd use `<device/mmio.h>`
( `nano +883 Documentation/contributing/coding_style.md`)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83320?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f47ddeda94d3882852d64c0052f8fb42b6b7ad2
Gerrit-Change-Number: 83320
Gerrit-PatchSet: 2
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No