Change in coreboot[master]: drivers/ipmi: Increase BMC timeout message level from INFO to ERR

List overview All Threads
Download

newer

older

[XS] Change in coreboot[master]:...

Change in coreboot[master]:...

Paul Menzel (Code Review)

2 Jun 2020 2 Jun '20

11:15 a.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41997 )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

drivers/ipmi: Increase BMC timeout message level from INFO to ERR

If the system is configured with a BMC, the user expects the BMC to be functional. If the initialization times out, than possible expected management features won’t work, so inform the user about that error.

It could also be debated, to make it a warning, but I chose to make it an error.

Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/ipmi/ipmi_kcs_ops.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41997/1

diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c index 0b90fb2..a5a963e 100644 --- a/src/drivers/ipmi/ipmi_kcs_ops.c +++ b/src/drivers/ipmi/ipmi_kcs_ops.c @@ -96,7 +96,7 @@ mdelay(100); } if (stopwatch_expired(&sw)) { - printk(BIOS_INFO, "IPMI: Waiting for BMC timed out\n"); + printk(BIOS_WARN, "IPMI: Waiting for BMC timed out\n"); /* Don't write tables if communication failed */ dev->enabled = 0; return;

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Michael Niewöhner (Code Review)

3 Jun 3 Jun

12:56 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41997 )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/41997/1/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:

https://review.coreboot.org/c/coreboot/+/41997/1/src/drivers/ipmi/ipmi_kcs_o... PS1, Line 99: BIOS_WARN -> BIOS_WARNING

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jun 2020 22:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

12:54 p.m.

Hello build bot (Jenkins), Patrick Rudolph, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41997

to look at the new patch set (#2).

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

drivers/ipmi: Increase BMC timeout message level from INFO to ERR

It could also be debated, to make it a warning, but I chose to make it an error.

Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/ipmi/ipmi_kcs_ops.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41997/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

12:59 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41997 )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41997/1/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:

https://review.coreboot.org/c/coreboot/+/41997/1/src/drivers/ipmi/ipmi_kcs_o... PS1, Line 99: BIOS_WARN

...

-> BIOS_WARNING

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 03 Jun 2020 10:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

12:59 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41997 )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 03 Jun 2020 10:59:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Jun 6 Jun

11:37 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41997 )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41997/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41997/2//COMMIT_MSG@10 PS2, Line 10: than then

https://review.coreboot.org/c/coreboot/+/41997/2//COMMIT_MSG@13 PS2, Line 13: , remove comma

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sat, 06 Jun 2020 09:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

17 Dec 17 Dec

3:46 p.m.

Hello build bot (Jenkins), Patrick Rudolph, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41997

to look at the new patch set (#3).

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

drivers/ipmi: Increase BMC timeout message level from INFO to ERR

If the system is configured with a BMC, the user expects the BMC to be functional. If the initialization times out, then possible expected management features won’t work, so inform the user about that error.

It could also be debated to make it a warning, but I chose to make it an error.

Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/ipmi/ipmi_kcs_ops.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41997/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin L Roth (Code Review)

7 Aug 7 Aug

10:39 p.m.

New subject: [XS] Change in coreboot[master]: drivers/ipmi: Increase BMC timeout message level from INFO to ERR

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41997?usp=email )

Change subject: drivers/ipmi: Increase BMC timeout message level from INFO to ERR ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I282ea7547e0f5b3cf3b44e4d42977a825180393a Gerrit-Change-Number: 41997 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-MessageType: abandon

263

days inactive

1424

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Martin L Roth (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)