build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 36:
(42 comments)
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_bp.c:
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 304: if (!cse_init_bp_info(false)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 304: if (!cse_init_bp_info(false)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 305: return false; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 305: return false; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 307: printk(BIOS_DEBUG, " No of partitions = %d\n", cse_bp_info.total_number_of_bp); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 307: printk(BIOS_DEBUG, " No of partitions = %d\n", cse_bp_info.total_number_of_bp); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 308: printk(BIOS_DEBUG, " current partition = %d\n", GET_BP(cse_bp_info.current_bp)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 308: printk(BIOS_DEBUG, " current partition = %d\n", GET_BP(cse_bp_info.current_bp)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 309: printk(BIOS_DEBUG, " Next partition = %d\n", GET_BP(cse_bp_info.next_bp)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 309: printk(BIOS_DEBUG, " Next partition = %d\n", GET_BP(cse_bp_info.next_bp)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 310: printk(BIOS_DEBUG, " Flags =0x%x\n", cse_bp_info.flags); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 310: printk(BIOS_DEBUG, " Flags =0x%x\n", cse_bp_info.flags); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 312: uint8_t bp_index; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 312: uint8_t bp_index; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 313: for (bp_index = 0; bp_index < cse_bp_info.total_number_of_bp; bp_index++) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 313: for (bp_index = 0; bp_index < cse_bp_info.total_number_of_bp; bp_index++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 314: printk(BIOS_DEBUG, " BP%d version = %d.%d.%d.%d\n", GET_BP(bp_index), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 314: printk(BIOS_DEBUG, " BP%d version = %d.%d.%d.%d\n", GET_BP(bp_index), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 315: cse_bp_info.bp_entries[bp_index].fw_version.major, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 315: cse_bp_info.bp_entries[bp_index].fw_version.major, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 316: cse_bp_info.bp_entries[bp_index].fw_version.minor, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 316: cse_bp_info.bp_entries[bp_index].fw_version.minor, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 317: cse_bp_info.bp_entries[bp_index].fw_version.hotfix, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 317: cse_bp_info.bp_entries[bp_index].fw_version.hotfix, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 318: cse_bp_info.bp_entries[bp_index].fw_version.build); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 318: cse_bp_info.bp_entries[bp_index].fw_version.build); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 319: printk(BIOS_DEBUG, " BP%d start offset = 0x%x\n", GET_BP(bp_index), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 319: printk(BIOS_DEBUG, " BP%d start offset = 0x%x\n", GET_BP(bp_index), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 320: cse_bp_info.bp_entries[bp_index].bp_start_offset); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 320: cse_bp_info.bp_entries[bp_index].bp_start_offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 321: printk(BIOS_DEBUG, " BP%d end offset = 0x%x\n", GET_BP(bp_index), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 321: printk(BIOS_DEBUG, " BP%d end offset = 0x%x\n", GET_BP(bp_index), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 322: cse_bp_info.bp_entries[bp_index].bp_end_offset); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 322: cse_bp_info.bp_entries[bp_index].bp_end_offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 323: printk(BIOS_DEBUG, " BP%d boot partition status = 0x%x\n", GET_BP(bp_index), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 323: printk(BIOS_DEBUG, " BP%d boot partition status = 0x%x\n", GET_BP(bp_index), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 324: cse_bp_info.bp_entries[bp_index].bp_status); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 324: cse_bp_info.bp_entries[bp_index].bp_status); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 325: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 325: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 326: return true; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/36/src/soc/intel/common/block... PS36, Line 326: return true; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)