Attention is currently required from: Taniya Das, Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches
......................................................................
Patch Set 10:
(3 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/b4e2b63c_c21fa28d
PS8, Line 103: if (hz != clk_cfg[idx].hz)
Please make sure you fix the num_perfs=0 in sc7180 as well.
Done
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/0f2c08f2_4386c96c
PS7, Line 412: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
There are three more tabs in front of this line than there should be (or is there something wrong ab […]
That actually shouldn't be there at all. THanks.
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/9860a8f3_75776ea1
PS8, Line 418: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
Yes that works too.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cfad7236241f4d03ff1a56683654649658b68fc
Gerrit-Change-Number: 63289
Gerrit-PatchSet: 10
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 09 Apr 2022 00:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment