Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support ......................................................................
Patch Set 17:
(6 comments)
File src/soc/mediatek/mt8196/gpio_eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/ef510dfd_f1f470d8?usp... : PS16, Line 11: DUMMY
INVALID
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/463d6b64_307c2898?usp... : PS16, Line 11: #define EINT_DUMMY 0
Use enum.
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/a3c9e612_d3041df6?usp... : PS16, Line 267:
Add `uint8_t index = eint_data[idx].index`.
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/35e33727_b319e5e3?usp... : PS16, Line 275: void *
uintptr_t
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/191244cf_d09ce63f?usp... : PS16, Line 282: (void *)
Remove
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/b76d6fe7_2f4fd1f9?usp... : PS16, Line 301: addr
`(void *)addr`
Done