Attention is currently required from: Deepti Deshatty, Paul Menzel, Shelley Chen.
Angel Pons has posted comments on this change by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/83087?usp=email )
Change subject: mb/google/brox: Adding support for batteryless booting
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83087/comment/927dc18e_ac1f1c4f?usp... :
PS3, Line 32: printk(BIOS_ERR, "Cannot find correct intel sku index.\n");
Add array size to the message?
I'd rather print `mchid`
https://review.coreboot.org/c/coreboot/+/83087/comment/e1630cf7_e7319a11?usp... :
PS3, Line 110: /* const struct device *policy_dev; */
Remove commented out thing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83087?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie36f16b2c938dce29cd2130a86fc8c08f5ba0902
Gerrit-Change-Number: 83087
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-Comment-Date: Sat, 15 Jun 2024 11:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org