Change in coreboot[master]: util/inteltool: Add H110 chipset support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: Revert...

Pavel Sayekat (Code Review)

28 Jul 2019 28 Jul '19

7:11 p.m.

Pavel Sayekat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 chipset support ......................................................................

util/inteltool: Add H110 chipset support

Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/1

diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index e48a2c5..1dfb896 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -1024,6 +1024,7 @@ gpio_registers = baytrail_score_ssus_gpio_registers; size = ARRAY_SIZE(baytrail_score_ssus_gpio_registers); break; + case PCI_DEVICE_ID_INTEL_H110: case PCI_DEVICE_ID_INTEL_B150: case PCI_DEVICE_ID_INTEL_CM236: case PCI_DEVICE_ID_INTEL_C236: diff --git a/util/inteltool/gpio_groups.c b/util/inteltool/gpio_groups.c index 3c0fedb..24d6c8e 100644 --- a/util/inteltool/gpio_groups.c +++ b/util/inteltool/gpio_groups.c @@ -1772,6 +1772,7 @@ size_t pad_stepping = 8;

switch (sb->device_id) { + case PCI_DEVICE_ID_INTEL_H110: case PCI_DEVICE_ID_INTEL_B150: case PCI_DEVICE_ID_INTEL_CM236: case PCI_DEVICE_ID_INTEL_C236:

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Pavel Sayekat (Code Review)

28 Jul 28 Jul

7:12 p.m.

Hello Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#2).

Change subject: util/inteltool: Add H110 chipset support ......................................................................

util/inteltool: Add H110 chipset support

Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/2

Nico Huber (Code Review)

7:42 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 chipset support ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool suggest adding `/gpio` or s/chipset/GPIO/

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 2 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 28 Jul 2019 17:42:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

7:46 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 chipset support ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool

...

suggest adding `/gpio` or s/chipset/GPIO/

agreed

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 2 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 28 Jul 2019 17:46:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

7:49 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#3).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/3

Nico Huber (Code Review)

7:50 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool

...

agreed

You should mention that this is about GPIO dumping, because the chipset was already known to inteltool, so I suggested to change it to either

util/inteltool/gpio: Add H110 chipset support

util/inteltool: Add H110 GPIO support

(I highlighted `util/inteltool` above, this is what I referred to with "adding `/gpio`". s/chipset/GPIO/ is a common command for editing tools like sed, it means s(ubstitute) chipset with GPIO)

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 2 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 28 Jul 2019 17:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

7:53 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

Patch Set 3:

...

Patch Set 2:

(1 comment)

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 3 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 28 Jul 2019 17:53:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

8:04 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#4).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/4

Pavel Sayekat (Code Review)

11:28 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#7).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/7

Pavel Sayekat (Code Review)

11:46 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#8).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/8

Pavel Sayekat (Code Review)

29 Jul 29 Jul

12:56 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#9).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/9

Pavel Sayekat (Code Review)

1:02 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#10).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/10

Pavel Sayekat (Code Review)

1:13 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#11).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/11

Pavel Sayekat (Code Review)

1:19 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#12).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/12

Pavel Sayekat (Code Review)

1:51 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Hello Angel Pons, Stefan Reinauer, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34602

to look at the new patch set (#13).

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34602/13

Pavel Sayekat (Code Review)

2:10 a.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

Patch Set 13:

(1 comment)

Its done.

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool

...

You should mention that this is about GPIO dumping, because the chipset […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 13 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Jul 2019 00:10:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Felix Held (Code Review)

7:03 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

Patch Set 13: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 13 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Jul 2019 17:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

7:50 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

Patch Set 13:

(1 comment)

Cool that it is in the merge cue :)

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34602/2//COMMIT_MSG@7 PS2, Line 7: util/inteltool

...

Done

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 13 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Jul 2019 17:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Pavel Sayekat Gerrit-MessageType: comment

Nico Huber (Code Review)

8:06 p.m.

New subject: Change in coreboot[master]: util/inteltool: Add H110 GPIO support

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34602 )

Change subject: util/inteltool: Add H110 GPIO support ......................................................................

util/inteltool: Add H110 GPIO support

Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34602 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c 2 files changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

switch (sb->device_id) { + case PCI_DEVICE_ID_INTEL_H110: case PCI_DEVICE_ID_INTEL_B150: case PCI_DEVICE_ID_INTEL_CM236: case PCI_DEVICE_ID_INTEL_C236:

-- To view, visit https://review.coreboot.org/c/coreboot/+/34602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ce22da3d201c2443bb5a7fcfd779c2c6ee71577 Gerrit-Change-Number: 34602 Gerrit-PatchSet: 14 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1883

days inactive

1884

days old

coreboot-gerrit@coreboot.org

18 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Held (Code Review)
Nico Huber (Code Review)
Pavel Sayekat (Code Review)