Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59175 )
Change subject: amdfwtool: Pack the PSP/BHD directory filling to functions ......................................................................
Patch Set 1:
(5 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132949): https://review.coreboot.org/c/coreboot/+/59175/comment/9a50ea4a_2dbf0d05 PS1, Line 458: static void fill_psp_dirctory(embedded_firmware *amd_romsig, void *pspdir, 'dirctory' may be misspelled - perhaps 'directory'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132949): https://review.coreboot.org/c/coreboot/+/59175/comment/5b7ac936_54a79622 PS1, Line 469: static void fill_bios_dirctory(embedded_firmware *amd_romsig, void *biosdir, 'dirctory' may be misspelled - perhaps 'directory'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132949): https://review.coreboot.org/c/coreboot/+/59175/comment/b7a633dc_d85b3672 PS1, Line 1636: fill_psp_dirctory(amd_romsig, pspdir, &ctx, comboable, soc_id); 'dirctory' may be misspelled - perhaps 'directory'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132949): https://review.coreboot.org/c/coreboot/+/59175/comment/cec3970a_642dfbe2 PS1, Line 1640: fill_psp_dirctory(amd_romsig, combo_dir, &ctx, comboable, soc_id); 'dirctory' may be misspelled - perhaps 'directory'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132949): https://review.coreboot.org/c/coreboot/+/59175/comment/22b639f7_5ba78905 PS1, Line 1668: fill_bios_dirctory(amd_romsig, biosdir, &ctx, soc_id); 'dirctory' may be misspelled - perhaps 'directory'?
-
build bot (Jenkins) (Code Review)