Patch set updated for coreboot: rockchip/rk3399: Configure USB3 controller to work in USB2 only mode

[Patrick Georgi]

Patrick Georgi ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16717

-gerrit

commit 4b1753c96132f4071f59457f10f10cfb12ec46ec
Author: Liangfeng Wu 
Date:   Thu Sep 15 17:16:54 2016 +0800

rockchip/rk3399: Configure USB3 controller to work in USB2 only mode

In USB2 only mode, the Type-C PHY will be held in reset and
    only the USB2 logic of the USB3 OTG controller and PHY will be
    used over the USB2 pins on the Type-C connector to support Low,
    Full and High-speed USB operation.

BRANCH=none
    BUG=chrome-os-partner:56425
    TEST=Go to recovery mode, plug a Type-C USB drive containing
    chrome OS image into both ports in all orientations, check if
    system can boot from USB.

Change-Id: Ic265c0c91c24f63b2f9c3106eb2bb277a589233b
    Signed-off-by: Patrick Georgi 
    Original-Commit-Id: a37ccc5b6019967483eac6b5a360d67bc3326e93
    Original-Change-Id: I582f04f84eef447ff0ba691ce60e9461ed31cfad
    Original-Signed-off-by: Liangfeng Wu 
    Original-Reviewed-on: https://chromium-review.googlesource.com/385837
    Original-Commit-Ready: Julius Werner 
    Original-Tested-by: Julius Werner 
    Original-Reviewed-by: Julius Werner 
---
 src/soc/rockchip/rk3399/usb.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/soc/rockchip/rk3399/usb.c b/src/soc/rockchip/rk3399/usb.c
index f638a1e..4c731bd 100644
--- a/src/soc/rockchip/rk3399/usb.c
+++ b/src/soc/rockchip/rk3399/usb.c
@@ -17,6 +17,9 @@
 #include <assert.h>
 #include <console/console.h>
 #include <delay.h>
+#include <soc/clock.h>
+#include <soc/grf.h>
+#include <soc/soc.h>
 #include <soc/usb.h>

/* SuperSpeed over Type-C is hard. We don't care about speed in firmware: just
@@ -86,12 +89,24 @@ static void setup_dwc3(struct rockchip_usb_dwc3 *dwc3)

void reset_usb_otg0(void)
 {
+	/* Keep whole USB OTG0 controller in reset, then
+	 * configure controller to work in USB 2.0 only mode. */
+	write32(&cru_ptr->softrst_con[18], RK_SETBITS(1 << 5));
+	write32(&rk3399_grf->usb3otg0_con1, RK_CLRSETBITS(0xf << 12, 1 << 0));
+	write32(&cru_ptr->softrst_con[18], RK_CLRBITS(1 << 5));
+
    printk(BIOS_DEBUG, "Starting DWC3 reset for USB OTG0\n");
    reset_dwc3(rockchip_usb_otg0_dwc3);
 }

void reset_usb_otg1(void)
 {
+	/* Keep whole USB OTG1 controller in reset, then
+	 * configure controller to work in USB 2.0 only mode. */
+	write32(&cru_ptr->softrst_con[18], RK_SETBITS(1 << 6));
+	write32(&rk3399_grf->usb3otg1_con1, RK_CLRSETBITS(0xf << 12, 1 << 0));
+	write32(&cru_ptr->softrst_con[18], RK_CLRBITS(1 << 6));
+
    printk(BIOS_DEBUG, "Starting DWC3 reset for USB OTG1\n");
    reset_dwc3(rockchip_usb_otg1_dwc3);
 }