Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36675 )
Change subject: Kconfig: Remove untrue comment ......................................................................
Kconfig: Remove untrue comment
In the vast majority of cases the bootdevice is the bottleneck and compression increases bootspeed.
Change-Id: Id0c11cf6d9a605d24e3148abb8d11a65d48a4529 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/36675/1
diff --git a/src/Kconfig b/src/Kconfig index 17bf545..ab72f08 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -154,9 +154,7 @@ depends on HAVE_RAMSTAGE # Default value set at the end of the file help - Compress ramstage to save memory in the flash image. Note - that decompression might slow down booting if the boot flash - is connected through a slow link (i.e. SPI). + Compress ramstage to save memory in the flash image.
config COMPRESS_POSTCAR bool "Compress postcar with LZ4"
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36675 )
Change subject: Kconfig: Remove untrue comment ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36675 )
Change subject: Kconfig: Remove untrue comment ......................................................................
Patch Set 1: Code-Review+2
Maybe it meant decompression algorithms that read things multiple times?
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36675 )
Change subject: Kconfig: Remove untrue comment ......................................................................
Kconfig: Remove untrue comment
In the vast majority of cases the bootdevice is the bottleneck and compression increases bootspeed.
Change-Id: Id0c11cf6d9a605d24e3148abb8d11a65d48a4529 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36675 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/Kconfig 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Aaron Durbin: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 4002d43..56ebe82 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -154,9 +154,7 @@ depends on HAVE_RAMSTAGE # Default value set at the end of the file help - Compress ramstage to save memory in the flash image. Note - that decompression might slow down booting if the boot flash - is connected through a slow link (i.e. SPI). + Compress ramstage to save memory in the flash image.
config COMPRESS_PRERAM_STAGES bool "Compress romstage and verstage with LZ4"
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Nico Huber (Code Review)