Attention is currently required from: YH Lin, Tim Wawrzynczak, Nick Vaccaro.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59938 )
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/taniks/gpio.c:
https://review.coreboot.org/c/coreboot/+/59938/comment/f5af46df_28d27cc8
PS3, Line 95: /* F22 : VNN_CTRL ==> VNN_CTRL */
: PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1),
: /* F23 : BP105_CTRL ==> PP1050_CTRL */
: PAD_CFG_NF(GPP_F23, NONE, DEEP, NF1),
Just to clarify, taniks does have the VNN and PP1050 bypass rails?
Yes,taniks has the byapss rails too.
https://review.coreboot.org/c/coreboot/+/59938/comment/9a43c77d_9b50c559
PS3, Line 199:
I also recommend deasserting SSD_PERST_L in the romstage GPIO table
Updated in latest patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 08 Dec 2021 05:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment