Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Poornima Tom, V Sowmya.
Kapil Porwal has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email )
Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/fw_config.c:
https://review.coreboot.org/c/coreboot/+/83077/comment/5493d6f7_cc174d55?usp... :
PS5, Line 97: wifi_pcie_enable_pad
Do you also want to configure the wake pin here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83077?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0584e91b5143c6df742961657d242c046409b3a
Gerrit-Change-Number: 83077
Gerrit-PatchSet: 5
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.corp-partner.google.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sun, 16 Jun 2024 05:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No