Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38449 )
Change subject: mb/portwell/m107: Remove the mainboard sleepstates.asl ......................................................................
mb/portwell/m107: Remove the mainboard sleepstates.asl
BUG=N/A TEST=build
Change-Id: Ifb45bc1f7f4d3744124d6797fb4c791fd5f227ca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/portwell/m107/acpi/sleepstates.asl M src/mainboard/portwell/m107/dsdt.asl 2 files changed, 3 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/38449/1
diff --git a/src/mainboard/portwell/m107/acpi/sleepstates.asl b/src/mainboard/portwell/m107/acpi/sleepstates.asl deleted file mode 100644 index 428fda2..0000000 --- a/src/mainboard/portwell/m107/acpi/sleepstates.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * Copyright (C) 2018 Eltan B.V. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Name(_S0, Package(){0x0,0x0,0x0,0x0}) -Name(_S4, Package(){0x6,0x6,0x0,0x0}) -Name(_S5, Package(){0x7,0x7,0x0,0x0}) diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl index 6fcb39a..707e48b 100644 --- a/src/mainboard/portwell/m107/dsdt.asl +++ b/src/mainboard/portwell/m107/dsdt.asl @@ -43,7 +43,8 @@ } }
- /* Mainboard specific sleep states */ - #include "acpi/sleepstates.asl" + #include <southbridge/intel/common/acpi/sleepstates.asl> + + /* Mainboard specific */ #include "acpi/mainboard.asl" }
Hello Frans Hendriks,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38449
to look at the new patch set (#2).
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
mb/portwell/m107: Remove mainboard sleepstates.asl
BUG=N/A TEST=build
Change-Id: Ifb45bc1f7f4d3744124d6797fb4c791fd5f227ca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/portwell/m107/acpi/sleepstates.asl M src/mainboard/portwell/m107/dsdt.asl 2 files changed, 3 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/38449/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38449 )
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
Patch Set 2: Code-Review+2
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38449
to look at the new patch set (#4).
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
mb/portwell/m107: Remove mainboard sleepstates.asl
BUG=N/A TEST=build
Change-Id: Ifb45bc1f7f4d3744124d6797fb4c791fd5f227ca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/portwell/m107/acpi/sleepstates.asl M src/mainboard/portwell/m107/dsdt.asl 2 files changed, 4 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/38449/4
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38449
to look at the new patch set (#5).
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
mb/portwell/m107: Remove mainboard sleepstates.asl
BUG=N/A TEST=build
Change-Id: Ifb45bc1f7f4d3744124d6797fb4c791fd5f227ca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/portwell/m107/acpi/sleepstates.asl M src/mainboard/portwell/m107/dsdt.asl 2 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/38449/5
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38449 )
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38449 )
Change subject: mb/portwell/m107: Remove mainboard sleepstates.asl ......................................................................
mb/portwell/m107: Remove mainboard sleepstates.asl
BUG=N/A TEST=build
Change-Id: Ifb45bc1f7f4d3744124d6797fb4c791fd5f227ca Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38449 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- D src/mainboard/portwell/m107/acpi/sleepstates.asl M src/mainboard/portwell/m107/dsdt.asl 2 files changed, 1 insertion(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/portwell/m107/acpi/sleepstates.asl b/src/mainboard/portwell/m107/acpi/sleepstates.asl deleted file mode 100644 index 428fda2..0000000 --- a/src/mainboard/portwell/m107/acpi/sleepstates.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2007-2009 coresystems GmbH - * Copyright (C) 2018 Eltan B.V. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Name(_S0, Package(){0x0,0x0,0x0,0x0}) -Name(_S4, Package(){0x6,0x6,0x0,0x0}) -Name(_S5, Package(){0x7,0x7,0x0,0x0}) diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl index ced3e10..586a5e1 100644 --- a/src/mainboard/portwell/m107/dsdt.asl +++ b/src/mainboard/portwell/m107/dsdt.asl @@ -43,6 +43,5 @@ } }
- /* Mainboard specific sleep states */ - #include "acpi/sleepstates.asl" + #include <southbridge/intel/common/acpi/sleepstates.asl> }
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)