Attention is currently required from: Michał Żygowski, Frans Hendriks, Tristan Corrick, Paul Menzel, Nick Vaccaro, Angel Pons, HAOUAS Elyes, Piotr Król, Wim Vervoorn.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
maybe we can remove the need for this CONFIG instead?
For all of the google boards, one reason for the warning is that the EC SIO device has _CRS and _PRS
but not _SRS. However, _CRS and _PRS match exactly, so I don't think _PRS is required here anyway. The same is also true for ECUI in the same file, src/ec/google/chromeec/acpi/superio.asl.
Many SIO devices in the tree also seem to have the same issue, where _PRS isn't listing anything different than is already in _CRS, so why is it there in the first place? Or I guess if there is a
compatibility concern, you could I suppose add an empty _SRS method too, because if the OSPM can only choose from the list in _PRS, and it already exactly matches _CRS, then _SRS wouldn't really take any effect anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Wed, 08 Dec 2021 21:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment