[S] Change in coreboot[master]: soc/intel/common: Restore to page 0 before reading SPD - coreboot-gerrit

11 Jul 2023


      Attention is currently required from: Kyösti Mälkki, Matt DeVillier, Sean Rhodes, Tim Crawford.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76382?usp=email )
Change subject: soc/intel/common: Restore to page 0 before reading SPD
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/76382/comment/bc35187d_4254acca :
PS3, Line 44: 	smbus_write_byte(SPD_PAGE_0, 0, 0);
...
I had another look at the smbus host code. […]
Added the conditionals to guard against page sizes
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76382?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad0a2024bd0ef39f6ab57ff7a6e6aa651d7882a6
Gerrit-Change-Number: 76382
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar coolstarorganization@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 11 Jul 2023 01:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: CoolStar coolstarorganization@gmail.com
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment