Attention is currently required from: Fei Yan, Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email )
Change subject: UPSTREAM: soc/mediatek/mt8188: devapc: set devapc permission for MFG ......................................................................
Patch Set 2:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82076/comment/76719776_02494116 : PS2, Line 7: UPSTREAM Remove `UPSTREAM:`.
https://review.coreboot.org/c/coreboot/+/82076/comment/99a48408_c0280910 : PS2, Line 9: Set MFG to domain 6. No need to start a new line for each sentence.
https://review.coreboot.org/c/coreboot/+/82076/comment/abdc7899_fb909320 : PS2, Line 13: . : So , so
https://review.coreboot.org/c/coreboot/+/82076/comment/62672366_9b9c608d : PS2, Line 14: So that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5 Missing `.` at the end.
File src/soc/mediatek/mt8188/devapc.c:
https://review.coreboot.org/c/coreboot/+/82076/comment/436ce243_f8711398 : PS2, Line 1788: // infra /* infra */
https://review.coreboot.org/c/coreboot/+/82076/comment/4608452b_fffc5a9a : PS2, Line 1807: { SUB_INFRACFG_AO_BASE + INFRA_AO_SEC_MFG_HYP2, infra_sec_mfg_hyp_init, dump_sec_mfg_hyp }, Line too long.
File src/soc/mediatek/mt8188/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/82076/comment/9c4689fa_7887f9cd : PS2, Line 31: one space