Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36248 )
Change subject: soc/intel/tigerlake: Update GPIOs for Tigerlake SOC
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36248/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36248/3//COMMIT_MSG@30
PS3, Line 30: BUG=None
no need to write bug or branch as we are in master but test is must
How can BUG be none when this commit fixes broken PMC?
https://review.coreboot.org/c/coreboot/+/36248/3/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/36248/3/src/soc/intel/tigerlake/inc...
PS3, Line 21: #define ABASE 0x40
looks like this is important and PMC was broken before
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04436a12e3fdd80e1f4ac0ecf73d78e467e4fe9f
Gerrit-Change-Number: 36248
Gerrit-PatchSet: 3
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 28 Oct 2019 15:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment