Attention is currently required from: Eric Lai, Kapil Porwal, Subrata Banik, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
TCSS 0/1 use dma0, TCSS 2/3 use dma1. You can find this in Intel doc.
Done
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/8a5b3237_7b8d1037 :
PS1, Line 89: device ref tcss_dma0 on
: chip drivers/intel/usb4/retimer
: register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
: use tcss_usb3_port1 as dfp[0].typec_port
: device generic 0 on end
: end
: end
: device ref tcss_dma1 on
: chip drivers/intel/usb4/retimer
: register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
: use tcss_usb3_port2 as dfp[0].typec_port
: device generic 0 on end
: end
: end
We can but it will not have any impact because the retimer chip driver is not using the device ID. […]
Thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc81f12ec6cc4af37bcc1fcf3164cbfa5612a443
Gerrit-Change-Number: 75578
Gerrit-PatchSet: 6
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 10:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment