Attention is currently required from: Bill XIE, Nico Huber, Patrick Rudolph, Julius Werner, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52601 )
Change subject: option: Add API for mainboard provided options
......................................................................
Patch Set 1:
(1 comment)
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/52601/comment/d4c33840_1d539e42
PS1, Line 13: const void *val
Uh, please don't introduce more void pointers... Even with a size parameter, it makes things unnecessarily complicated and error-prone.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52601
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5bbb5b3353d862c5533f90ced4824eec27ca3b9
Gerrit-Change-Number: 52601
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 11:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment