Attention is currently required from: Bao Zheng, Jason Glenesk, Zheng Bao, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72963 )
Change subject: mb/amd/birman: Add support for 32M flash ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Since Birman only has a 32M flash, once building for a 32M flash works, I do not see the need to keep the 16M layouts around.
File src/mainboard/amd/birman/board-32M.fmd:
https://review.coreboot.org/c/coreboot/+/72963/comment/ada37aa0_e98ce842 PS4, Line 9: AMDFWBODY(CBFS) @2047K The `(CBFS)` should be removed due to updates in CB:72703
The Birman EC binary does not work in the upper 16M region, so go ahead and reserve the entire region for AMDFWBODY.
File src/mainboard/amd/birman/chromeos-32M.fmd:
https://review.coreboot.org/c/coreboot/+/72963/comment/c2fa8bba_19b21066 PS4, Line 35: AMDFWBODY(CBFS) @2047K Same comment as above
-
Fred Reitberger (Code Review)