Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Raj Astekar.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83787?usp=email )
Change subject: mb/google/brox: Control HDMI Hot Plug Detect(HPD) during S0ix ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/mainboard/google/brox/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83787/comment/0fd4b925_7d7a3aa6?usp... : PS1, Line 18: : #define HDMI_HPD GPP_A18 can we move this macro inside https://github.com/coreboot/coreboot/blob/main/src/mainboard/google/brox/var... ?
https://review.coreboot.org/c/coreboot/+/83787/comment/35927577_2f2ec806?usp... : PS1, Line 199: mainboard_generate_hdmi_hpd_disable Thinking loud here. There may be too few scenarios where we may not IGPU enabled, doesn't it make sense to skip just PAD configuration when IGPU itself is not enabled ?
```suggestion const struct device *igpu = DEV_PTR(igpu); if (igpu) mainboard_generate_hdmi_hpd_disable(); ```