Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Raul Rangel, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72939?usp=email )
Change subject: util/amdfwtool: Deal with psp position in flash offset directly ......................................................................
Patch Set 23:
(2 comments)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/72939/comment/5737d01f_8202bbe8 : PS20, Line 82: default AMD_FWM_POSITION_20000 if !AMD_FWM_POSITION_420000_DEFAULT && \ : !AMD_FWM_POSITION_820000_DEFAULT && \ : !AMD_FWM_POSITION_C20000_DEFAULT && \ : !AMD_FWM_POSITION_E20000_DEFAULT && \ : !AMD_FWM_POSITION_F20000_DEFAULT && \ : !AMD_FWM_POSITION_FA0000_DEFAULT : default AMD_FWM_POSITION_420000 if AMD_FWM_POSITION_420000_DEFAULT : default AMD_FWM_POSITION_820000 if AMD_FWM_POSITION_820000_DEFAULT : default AMD_FWM_POSITION_C20000 if AMD_FWM_POSITION_C20000_DEFAULT : default AMD_FWM_POSITION_E20000 if AMD_FWM_POSITION_E20000_DEFAULT : default AMD_FWM_POSITION_F20000 if AMD_FWM_POSITION_F20000_DEFAULT : default AMD_FWM_POSITION_FA0000 if AMD_FWM_POSITION_FA0000_DEFAULT :
I think this can be simplified by flipping the order and just leaving the last entry as `default AMD […]
Done
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/72939/comment/8451e37c_268257e7 : PS21, Line 150: STONEYRIDGE_FWM_POSITION)
Gardenia can not pass the identical test.
Done. With https://review.coreboot.org/c/coreboot/+/76764, images smaller that 16M can pass the identical test.