Attention is currently required from: Martin Roth, Michał Żygowski, Marshall Dawson, Subrata Banik, Nikolai Vyssotski, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )
Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header
......................................................................
Patch Set 4: -Code-Review
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56190/comment/b428f8b7_cae846b1
PS4, Line 12: This field is not used in coreboot yet.
This is not really correct. It is used by some Intel platforms.
https://review.coreboot.org/c/coreboot/+/56190/comment/e47759db_52e68659
PS4, Line 13: Allow headers of both lengths to be accepted.
Can you please add the detail that the check for header length in `looks_like_fsp_header()` is updated to look for a minimum length based on version and the reason for that?
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/56190/comment/7bff07cc_56376d58
PS4, Line 17: if (CONFIG(PLATFORM_USES_FSP2_2))
please, no spaces at the start of a line
Please fix this and the comments below.
https://review.coreboot.org/c/coreboot/+/56190/comment/7c5e1f36_a230f335
PS4, Line 36: fsp_header_length < fsp_hdr_get_expected_min_length()
Can you please add a comment here explaining why header length is compared against a minimum value for the version?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8422447b2cff0a6c536e13014905ffa15c70586
Gerrit-Change-Number: 56190
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Wed, 14 Jul 2021 03:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment