Attention is currently required from: Martin Roth, Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/51133 )
Change subject: Add support to switch LSPCON modes ......................................................................
Patch Set 12:
(5 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/bec5c63c_271e2b6a PS9, Line 11: The chip defaults to LS mode.
Maybe explain this, e.g. […]
Done
https://review.coreboot.org/c/libgfxinit/+/51133/comment/db062883_bf09ec0e PS9, Line 16: level shifter mode
`level-shifter mode` would probably read better, or `LS mode` […]
Done
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/2653e0d4_4419c10a PS11, Line 9: highly-cursed
I'd drop it. […]
Gone
Patchset:
PS11:
Looks I forgot to publish some old drafts, sorry. […]
IIRC, last time I checked it didn't cause any issues. I think I had problems when the LSPCON detection didn't work properly.
File common/hw-gfx-dp_dual_mode.adb:
https://review.coreboot.org/c/libgfxinit/+/51133/comment/cea6c09f_2be0ca73 PS11, Line 87: end case;
Could also remove all the pragmas here and put a single one around each call. […]
SPARK still complains 😭
-
Angel Pons (Code Review)