HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33733
Change subject: util/cbfstool/flashmap: Correct local includes ......................................................................
util/cbfstool/flashmap: Correct local includes
Change-Id: I78ba7afd2085c7e9c93e892470111bfee154bb04 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/cbfstool/flashmap/fmap.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/33733/1
diff --git a/util/cbfstool/flashmap/fmap.c b/util/cbfstool/flashmap/fmap.c index f1d2fb9..06f179f 100644 --- a/util/cbfstool/flashmap/fmap.c +++ b/util/cbfstool/flashmap/fmap.c @@ -48,10 +48,9 @@ #include <limits.h> #include <assert.h>
-#include <fmap.h> -#include <valstr.h> - +#include "fmap.h" #include "kv_pair.h" +#include "valstr.h"
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33733 )
Change subject: util/cbfstool/flashmap: Correct local includes ......................................................................
Patch Set 1: Code-Review+2
This seems easy to automate. e.g. for each <> include, check if a local file exists with that name.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33733 )
Change subject: util/cbfstool/flashmap: Correct local includes ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33733 )
Change subject: util/cbfstool/flashmap: Correct local includes ......................................................................
util/cbfstool/flashmap: Correct local includes
Change-Id: I78ba7afd2085c7e9c93e892470111bfee154bb04 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33733 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/cbfstool/flashmap/fmap.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/cbfstool/flashmap/fmap.c b/util/cbfstool/flashmap/fmap.c index f1d2fb9..06f179f 100644 --- a/util/cbfstool/flashmap/fmap.c +++ b/util/cbfstool/flashmap/fmap.c @@ -48,10 +48,9 @@ #include <limits.h> #include <assert.h>
-#include <fmap.h> -#include <valstr.h> - +#include "fmap.h" #include "kv_pair.h" +#include "valstr.h"
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)