[L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port - coreboot-gerrit

2 Aug 2024


      Attention is currently required from: Nicholas Chin, Paul Menzel, Riku Viitanen.
Nico Huber has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email )
Change subject: mb/hp: Add Compaq Elite 8300 CMT port
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/hp/compaq_elite_8300_cmt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79745/comment/a2ec780e_b7256c8c?usp... :
PS15, Line 65: 			device ref pcie_rp5 on end
Here's your "duplicate device". We used to allow this to model devices with
multiple downstream buses. Now the mistake is more obvious, error message
could be better of course.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363
Gerrit-Change-Number: 79745
Gerrit-PatchSet: 15
Gerrit-Owner: Riku Viitanen riku.viitanen@protonmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nicholas Chin nic.c3.14@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Riku Viitanen riku.viitanen@protonmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 02 Aug 2024 10:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No