Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43703 )
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
arch/x86/smbios: Fix type4 for EDK2
Mark the CPU as enabled and the socket as poulated. EDK2 tests this flags before further reading this structure.
Change-Id: Ic545bb47c502cb9d2352ba6d43eaed8c97229c02 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43703/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 61b6aa2..375f318 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -734,6 +734,8 @@ t->l2_cache_handle = 0xffff; t->l3_cache_handle = 0xffff; t->serial_number = smbios_add_string(t->eos, smbios_processor_serial_number()); + t->status = SMBIOS_PROCESSOR_STATUS_CPU_ENABLED | + SMBIOS_PROCESSOR_STATUS_POPULATED; t->processor_upgrade = get_socket_type(); len = t->length + smbios_string_table_len(t->eos); if (cpu_have_cpuid() && cpuid_get_max_func() >= 0x16) { diff --git a/src/include/smbios.h b/src/include/smbios.h index 8cdd58a..45c550a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -405,6 +405,11 @@ u8 eos[2]; } __packed;
+/* defines for smbios_type4 */ + +#define SMBIOS_PROCESSOR_STATUS_POPULATED (1 << 6) +#define SMBIOS_PROCESSOR_STATUS_CPU_ENABLED (1 << 0) + /* defines for supported_sram_type/current_sram_type */
#define SMBIOS_CACHE_SRAM_TYPE_OTHER (1 << 0)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43703 )
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG@9 PS1, Line 9: poulated po*p*ulated
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG@10 PS1, Line 10: this these
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43703 )
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG@9 PS1, Line 9: poulated
po*p*ulated
Done
https://review.coreboot.org/c/coreboot/+/43703/1//COMMIT_MSG@10 PS1, Line 10: this
these
Done
Hello Philipp Deppenwiese, build bot (Jenkins), Christian Walter, Angel Pons, Marcello Sylvester Bauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43703
to look at the new patch set (#2).
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
arch/x86/smbios: Fix type4 for EDK2
Mark the CPU as enabled and the socket as populated. EDK2 tests these flags before further reading this structure.
Change-Id: Ic545bb47c502cb9d2352ba6d43eaed8c97229c02 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43703/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43703 )
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
Patch Set 2: Code-Review+2
With this and the parent, an old CorebootPayloadPkg tianocore payload on Asrock B85M Pro4 correctly says there are 8192 MB of RAM (two 4 GiB sticks).
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43703 )
Change subject: arch/x86/smbios: Fix type4 for EDK2 ......................................................................
arch/x86/smbios: Fix type4 for EDK2
Mark the CPU as enabled and the socket as populated. EDK2 tests these flags before further reading this structure.
Change-Id: Ic545bb47c502cb9d2352ba6d43eaed8c97229c02 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43703 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index c38c369..070c7ea 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -734,6 +734,8 @@ t->l2_cache_handle = 0xffff; t->l3_cache_handle = 0xffff; t->serial_number = smbios_add_string(t->eos, smbios_processor_serial_number()); + t->status = SMBIOS_PROCESSOR_STATUS_CPU_ENABLED | + SMBIOS_PROCESSOR_STATUS_POPULATED; t->processor_upgrade = get_socket_type(); len = t->length + smbios_string_table_len(t->eos); if (cpu_have_cpuid() && cpuid_get_max_func() >= 0x16) { diff --git a/src/include/smbios.h b/src/include/smbios.h index 8cdd58a..45c550a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -405,6 +405,11 @@ u8 eos[2]; } __packed;
+/* defines for smbios_type4 */ + +#define SMBIOS_PROCESSOR_STATUS_POPULATED (1 << 6) +#define SMBIOS_PROCESSOR_STATUS_CPU_ENABLED (1 << 0) + /* defines for supported_sram_type/current_sram_type */
#define SMBIOS_CACHE_SRAM_TYPE_OTHER (1 << 0)
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)