Attention is currently required from: Tarun Tuli, Sumeet R Pawnikar, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )
Change subject: soc/intel/meteoerlake: set power limits dynamically ......................................................................
Patch Set 3:
(4 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/74380/comment/666a1fab_8bd561e6 PS2, Line 33: static const struct
As of now it's only for systemagent.c file.
in that case can we move this into systemagent.c itself and use as a local data structure ?
File src/soc/intel/meteorlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/74380/comment/945e8d49_62849981 PS3, Line 147: configure_tdp do we expect someone will call this function outside soc_systemagent_init() ? if no, then please make it static ?
https://review.coreboot.org/c/coreboot/+/74380/comment/b74ecfba_a088617c PS3, Line 170: /* Choose power limits configuration based on the CPU SA PCI ID and : * CPU TDP value. */ can u please use ``` /* * */ ```
https://review.coreboot.org/c/coreboot/+/74380/comment/21053984_e60a63ee PS3, Line 194: Ramstage ramstage?