Attention is currently required from: KunYi Chen.
Elyes Haouas has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 28:
(4 comments)
Patchset:
PS28: Please include only what you use NB: I've checked only src/mainboard/lattepanda/mu/romstage_fsp_params.c and src/mainboard/lattepanda/mu/smihandler.c
File src/mainboard/lattepanda/mu/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/68d91f00_c095ad6d?usp... : PS28, Line 3: #include <assert.h> : #include <console/console.h> : #include <fsp/api.h> : #include <soc/romstage.h> : #include <spd_bin.h> : #include <soc/meminit.h> : #include <baseboard/variants.h> I'm not sure if you are using all of those files
File src/mainboard/lattepanda/mu/smihandler.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/4ef5f213_7e7558c6?usp... : PS28, Line 4: #include <arch/io.h> not sure if this is used
https://review.coreboot.org/c/coreboot/+/83719/comment/531f6b7e_f305732e?usp... : PS28, Line 6: #include <intelblocks/smihandler.h> looks like it is not used