Attention is currently required from: Furquan Shaikh, Martin Roth, Meera Ravindranath, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49474 )
Change subject: drivers/intel/fsp2_0: Add support for MP services2 PPI
......................................................................
Patch Set 9:
(4 comments)
File src/drivers/intel/fsp2_0/ppi/mp_service1.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/ababcb41_df31fcbd
PS9, Line 13:
nit: space instead of tab.
Done
https://review.coreboot.org/c/coreboot/+/49474/comment/84155b10_432af945
PS9, Line 58:
nit: blank line not required -- to keep it consistent with above functions.
done.
File src/drivers/intel/fsp2_0/ppi/mp_service2.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/0ab44c5f_49b5662c
PS9, Line 14:
nit: space instead of tab.
Done
https://review.coreboot.org/c/coreboot/+/49474/comment/2d81afd1_c04f2a68
PS9, Line 67:
nit: blank line not required -- to keep it consistent with above functions.
done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id74baf17fb90147d229c78be90268fdc3ec1badc
Gerrit-Change-Number: 49474
Gerrit-PatchSet: 9
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 05 Feb 2021 03:56:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment