Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56924 )
Change subject: mb/google/dedede/var/driblee: Generate RAM ID and SPD file ......................................................................
mb/google/dedede/var/driblee: Generate RAM ID and SPD file
Add the support RAM parts for Driblee. Here is the ram part number list: 1. Hynix H9HCNNNBKMMLXR-NEE 2. Micron MT53E512M32D2NP-046 WT:F 3. Samsung K4U6E3S4AA-MGCR 4. Micron MT53E512M32D1NP-046 WT:B
BUG=b:195619346 BRANCH=keeby TEST=emerge-keeby coreboot
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I683acb91ec13cbd772e732d7f81152ceb3cefc1c Reviewed-on: https://review.coreboot.org/c/coreboot/+/56924 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc M src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt 3 files changed, 10 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc b/src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc index b0ca222..42c6cf4 100644 --- a/src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:F, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B diff --git a/src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt index fa24790..0dbc38e 100644 --- a/src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E512M32D2NP-046 WT:F 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +MT53E512M32D1NP-046 WT:B 0 (0000) diff --git a/src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt index e4258b5..c1e9e0c 100644 --- a/src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt @@ -1,11 +1,4 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. -# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. - -# Part Name +H9HCNNNBKMMLXR-NEE +MT53E512M32D2NP-046 WT:F +K4U6E3S4AA-MGCR +MT53E512M32D1NP-046 WT:B
-
Felix Held (Code Review)