Change in coreboot[master]: /mb/google/hatch/var/draini: Add new memory support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

7 Nov 2019 7 Nov '19

10:06 p.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/draini: Add new memory support ......................................................................

/mb/google/hatch/var/draini: Add new memory support

1. ram id 8: 16G 2666 2 bank groups memory 2. ram id 9: 16G 3200 4 bank groups memory

BUG=b:142762387 TEST=boot with memory (KAAG165WA-BCT/H5ANAG6NCMR-XNC)

Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/Makefile.inc 1 file changed, 10 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36667/1

diff --git a/src/mainboard/google/hatch/variants/dratini/Makefile.inc b/src/mainboard/google/hatch/variants/dratini/Makefile.inc index 8b7e3d1..c29c92d 100644 --- a/src/mainboard/google/hatch/variants/dratini/Makefile.inc +++ b/src/mainboard/google/hatch/variants/dratini/Makefile.inc @@ -12,14 +12,16 @@ ## GNU General Public License for more details. ##

-SPD_SOURCES = 4G_2400 # 0b000 -SPD_SOURCES += empty_ddr4 # 0b001 -SPD_SOURCES += 8G_2400 # 0b010 -SPD_SOURCES += 8G_2666 # 0b011 -SPD_SOURCES += 16G_2400 # 0b100 -SPD_SOURCES += 16G_2666 # 0b101 -SPD_SOURCES += 8G_3200 # 0b110 -SPD_SOURCES += 16G_3200 # 0b111 +SPD_SOURCES = 4G_2400 # 0b000 +SPD_SOURCES += empty_ddr4 # 0b001 +SPD_SOURCES += 8G_2400 # 0b010 +SPD_SOURCES += 8G_2666 # 0b011 +SPD_SOURCES += 16G_2400 # 0b100 +SPD_SOURCES += 16G_2666 # 0b101 +SPD_SOURCES += 8G_3200 # 0b110 +SPD_SOURCES += 16G_3200 # 0b111 +SPD_SOURCES += 16G_2666_2bg # 0b1000 +SPD_SOURCES += 16G_3200_4bg # 0b1001

bootblock-y += gpio.c ramstage-y += gpio.c

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Chen Wisley (Code Review)

12 Nov 12 Nov

5:05 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/draini: Add new memory support ......................................................................

Patch Set 1:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 01:05:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:54 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/draini: Add new memory support ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 03:54:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

13 Nov 13 Nov

1:31 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/draini: Add new memory support ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG@7 PS1, Line 7: draini nit: dratini

https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/... PS1, Line 18: b0 maybe zero-pad these entries to the same length as the new entries?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 09:31:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

1:40 a.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36667

to look at the new patch set (#2).

Change subject: /mb/google/hatch/var/draini: Add new memory support ......................................................................

/mb/google/hatch/var/draini: Add new memory support

1. ram id 8: 16G 2666 2 bank groups memory 2. ram id 9: 16G 3200 4 bank groups memory

BUG=b:142762387 TEST=boot with memory (KAAG165WA-BCT/H5ANAG6NCMR-XNC)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36667/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

1:41 a.m.

New subject: Change in coreboot[master]: /mb/google/hatch/var/dratini: Add new memory support

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36667

to look at the new patch set (#3).

Change subject: /mb/google/hatch/var/dratini: Add new memory support ......................................................................

/mb/google/hatch/var/dratini: Add new memory support

1. ram id 8: 16G 2666 2 bank groups memory 2. ram id 9: 16G 3200 4 bank groups memory

BUG=b:142762387 TEST=boot with memory (KAAG165WA-BCT/H5ANAG6NCMR-XNC)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36667/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

1:42 a.m.

New subject: Change in coreboot[master]: /mb/google/hatch/var/dratini: Add new memory support

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/dratini: Add new memory support ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/... PS1, Line 18: b0

...

maybe zero-pad these entries to the same length as the new entries?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 09:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Chen Wisley (Code Review)

1:42 a.m.

New subject: Change in coreboot[master]: /mb/google/hatch/var/dratini: Add new memory support

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/dratini: Add new memory support ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG@7 PS1, Line 7: draini

...

nit: dratini

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 09:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

7:42 a.m.

New subject: Change in coreboot[master]: /mb/google/hatch/var/dratini: Add new memory support

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/dratini: Add new memory support ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 13 Nov 2019 15:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

14 Nov 14 Nov

3:29 a.m.

New subject: Change in coreboot[master]: /mb/google/hatch/var/dratini: Add new memory support

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36667 )

Change subject: /mb/google/hatch/var/dratini: Add new memory support ......................................................................

/mb/google/hatch/var/dratini: Add new memory support

1. ram id 8: 16G 2666 2 bank groups memory 2. ram id 9: 16G 3200 4 bank groups memory

BUG=b:142762387 TEST=boot with memory (KAAG165WA-BCT/H5ANAG6NCMR-XNC)

Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36667 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dratini/Makefile.inc 1 file changed, 10 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/dratini/Makefile.inc b/src/mainboard/google/hatch/variants/dratini/Makefile.inc index 8b7e3d1..4ed09c9 100644 --- a/src/mainboard/google/hatch/variants/dratini/Makefile.inc +++ b/src/mainboard/google/hatch/variants/dratini/Makefile.inc @@ -12,14 +12,16 @@ ## GNU General Public License for more details. ##

-SPD_SOURCES = 4G_2400 # 0b000 -SPD_SOURCES += empty_ddr4 # 0b001 -SPD_SOURCES += 8G_2400 # 0b010 -SPD_SOURCES += 8G_2666 # 0b011 -SPD_SOURCES += 16G_2400 # 0b100 -SPD_SOURCES += 16G_2666 # 0b101 -SPD_SOURCES += 8G_3200 # 0b110 -SPD_SOURCES += 16G_3200 # 0b111 +SPD_SOURCES = 4G_2400 # 0b0000 +SPD_SOURCES += empty_ddr4 # 0b0001 +SPD_SOURCES += 8G_2400 # 0b0010 +SPD_SOURCES += 8G_2666 # 0b0011 +SPD_SOURCES += 16G_2400 # 0b0100 +SPD_SOURCES += 16G_2666 # 0b0101 +SPD_SOURCES += 8G_3200 # 0b0110 +SPD_SOURCES += 16G_3200 # 0b0111 +SPD_SOURCES += 16G_2666_2bg # 0b1000 +SPD_SOURCES += 16G_3200_4bg # 0b1001

bootblock-y += gpio.c ramstage-y += gpio.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/36667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c Gerrit-Change-Number: 36667 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com Gerrit-MessageType: merged

1831

days inactive

1837

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Chen Wisley (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Tim Wawrzynczak (Code Review)