Attention is currently required from: Christian Walter, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63464 )
Change subject: mb/prodrive/atlas: Update kconfig ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/prodrive/atlas/Kconfig:
https://review.coreboot.org/c/coreboot/+/63464/comment/97574fdb_2db43439 PS2, Line 3: select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR This was removed in CB:63339
https://review.coreboot.org/c/coreboot/+/63464/comment/96d466c8_f766bcd5 PS2, Line 5: select DRIVERS_I2C_GENERIC : select DRIVERS_INTEL_DPTF : select DRIVERS_SPI_ACPI : select DRIVERS_USB_ACPI These options enable various devicetree chip drivers, but just selecting them isn't really useful. It would make more sense to select these in the same commit that updates the devicetree.
https://review.coreboot.org/c/coreboot/+/63464/comment/a3ddd6db_146fb76d PS2, Line 9: select DRIVERS_UART_8250IO Why is this needed? AFAIK, the SerialIO UARTs are configured to use MMIO (INTEL_LPSS_UART_FOR_CONSOLE selects DRIVERS_UART_8250MEM_32).
https://review.coreboot.org/c/coreboot/+/63464/comment/6ab02271_d6dd6c2b PS2, Line 17: : config IGNORE_IASL_MISSING_DEPENDENCY : def_bool y Why is this needed?
-
Angel Pons (Code Review)