[M] Change in coreboot[main]: chromeec: support reading long battery strings - coreboot-gerrit

2 Jul 2024


      Attention is currently required from: Forest Mittelberg, Paul Menzel, Peter Marheine.
Subrata Banik has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/coreboot/+/82775?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: chromeec: support reading long battery strings
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/82775/comment/50d6c551_0ee2a77f?usp... :
PS2, Line 61: string index
nit: if you could highlight in the comment section the meaning of index 1-3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82775?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia29cacb7d86402490f9ac458f0be50e3f2192b04
Gerrit-Change-Number: 82775
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 05:37:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No