Attention is currently required from: Christian Walter, Felix Singer, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Tim Crawford.
Yuchen He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75972?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for PchHdaAudioLinkHda dt option
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/starlabs/starbook/variants/cml/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/75972/comment/0af5a936_7ee65d3b :
PS1, Line 180: register PchHdaAudioLinkHda = true
Still one tab missing
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75972?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2df7271bdc3d6c30bae75188e150fb348d872ab9
Gerrit-Change-Number: 75972
Gerrit-PatchSet: 3
Gerrit-Owner: Yuchen He
yuchenhe126@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 21 Jun 2023 17:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment