[S] Change in coreboot[master]: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order - coreboot-gerrit

16 Nov 2022


      Attention is currently required from: Angel Pons, Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69670 )
Change subject: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS1:
...
Maybe we should drop the code instead?
Good question, I assume this is about the OS gfx driver calling us. But I don't
think we have anything implemented to handle that.
Patchset:
PS2: 
Note, haswell/gma has a similar issue even going down into enable_tco_sci()...
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517
Gerrit-Change-Number: 69670
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 10:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment