Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52895 )
Change subject: include/console: Fix duplicate entry of postcode 0x79 ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52895/comment/97bc07fe_3a6b868a PS3, Line 13: to make the ramstage postcodes appear in an incremental order. This should be done in another commit.
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52895/comment/6efea113_5e1e2d1c PS3, Line 190: POST_BS_WRITE_TABLES grep says this macro is unused. I'd rather renumber (or remove) this instead of POST_PRE_HARDWAREMAIN.
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52895/comment/f96c04eb_98fc5f45 PS1, Line 191: /** : * \brief Pre call to RAM stage main() : * : * POSTed right before RAM stage main() is called from c_start.S : */ : #define POST_PRE_HARDWAREMAIN 0x7c : : /** : * \brief Entry into coreboot in RAM stage main() : * : * This is the first call in hardwaremain.c. If this code is POSTed, then : * ramstage has successfully loaded and started executing. : */ : #define POST_ENTRY_RAMSTAGE 0x80
Perfect, done
I'd say it doesn't matter.