Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31832 )
Change subject: mb/gigabyte/ga-h61ma-d3v: Add new mainboard as variant ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... PS1, Line 25: select NORTHBRIDGE_INTEL_SANDYBRIDGE if BOARD_GIGABYTE_GA_H61MA_D3V : select NORTHBRIDGE_INTEL_IVYBRIDGE if BOARD_GIGABYTE_GA_H61M_S2PV
why this distinction? H61 is a sandybridge gen PCH?
The selected northbridge in the code should not make much difference except for libgfxinit, which will fail to lightup if the selected northbridge doesn't match the installed CPU (the "northbridge" is part of the CPU in SNB/IVB platforms).
When I ported the GA-H61M-S2PV, I had a SNB i3 in it. I later put an IVB i5 in it, which made libgfxinit stop working in the default config. Now that I added the GA-H61MA-D3V, which has a SNB CPU, I thought I would fix libgfxinit on my configurations so that I can send a board_status with working libgfxinit.
NB this is a workaround that will be fixed with libgfxinit's dyncpu patches, which would make this distinction irrelevant.
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/hda_verb.c:
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... PS1, Line 6: * This program is free software; you can redistribute it and/or
Link it in the variant dir?
I would need to leave a dummy file here, though.
https://review.coreboot.org/#/c/31832/2/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c:
https://review.coreboot.org/#/c/31832/2/src/mainboard/gigabyte/ga-h61m-s2pv/... PS2, Line 66: CONFIG(BOARD_GIGABYTE_GA_H61M_S2PV)
!CONFIG(NO_UART_ON_SUPERIO)
Ack