Change in coreboot[master]: mb/google/hatch: Add smart battery I2C passthrough for Dratini
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
mb/google/hatch: Add smart battery I2C passthrough for Dratini
Some smart battery patches have been backported to the ChromeOS 4.19 kernel, and userspace can now access smart battery data from sysfs instead of using the hacky ectool instead.
BUG=chromium:1047277 TEST=confirmed a /sys/class/power_supply/sbs-i2c device shows up
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I43687e63e4c1a7756c117129ced20749afc1b9e2 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb 3 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/43451/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 3f0e83b..f369949 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -28,6 +28,7 @@ select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_ESPI + select EC_GOOGLE_CHROMEEC_I2C_TUNNEL select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 2bfcc26..3f9d14a 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -169,6 +169,25 @@ device spi 1 on end end # FPMCU end # GSPI #1 + device pci 1f.0 on + chip ec/google/chromeec + device pnp 0c09.0 on + chip ec/google/chromeec/i2c_tunnel + register "uid" = "1" + register "remote_bus" = "5" + device generic 0 on + chip drivers/i2c/generic + register "hid" = ""ACPI_DT_NAMESPACE_HID"" + register "name" = ""SBS0"" + register "uid" = "1" + register "compat_string" = ""sbs,sbs-battery"" + device i2c 0b on end + end + end + end + end + end + end # eSPI Interface device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98357A"" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 34d2358..a73be08 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -196,5 +196,25 @@ device spi 1 on end end # FPMCU end # GSPI #1 + + device pci 1f.0 on + chip ec/google/chromeec + device pnp 0c09.0 on + chip ec/google/chromeec/i2c_tunnel + register "uid" = "1" + register "remote_bus" = "5" + device generic 0.0 on + chip drivers/i2c/generic + register "hid" = "ACPI_DT_NAMESPACE_HID" + register "desc" = ""Smart Battery (tunneled)"" + register "name" = ""SBS0"" + register "compat_string" = ""sbs,sbs-battery"" + device i2c 0b on end + end + end + end + end + end + end # eSPI Interface end end
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 1:
(1 comment)
Any reason to not make this change for entire hatch family?
https://review.coreboot.org/c/coreboot/+/43451/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43451/1/src/mainboard/google/hatch/... PS1, Line 175: Use tabs instead of spaces here and in the lines below.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Any reason to not make this change for entire hatch family?
The diagnostics team has only requested this for 4 devices, because only one OEM asks for the newly-available information in sysfs. I still have it on my list of things to do to see if we can switch from using BAT0 to just the sbs driver 😊 This allows the diagnostics team to get away from a single, very hacky use of ectool to get at the smart battery directly.
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43451
to look at the new patch set (#2).
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
mb/google/hatch: Add smart battery I2C passthrough for Dratini
Some smart battery patches have been backported to the ChromeOS 4.19 kernel, and userspace can now access smart battery data from sysfs instead of using the hacky ectool instead.
BUG=chromium:1047277 TEST=confirmed a /sys/class/power_supply/sbs-i2c device shows up
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I43687e63e4c1a7756c117129ced20749afc1b9e2 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/43451/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 2:
Oops patchset 1 still had my helios changes for testing
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43451/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43451/2/src/mainboard/google/hatch/... PS2, Line 175: chip ec/google/chromeec/i2c_tunnel oh no, spaces in indentation!
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43451
to look at the new patch set (#3).
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
mb/google/hatch: Add smart battery I2C passthrough for Dratini
Some smart battery patches have been backported to the ChromeOS 4.19 kernel, and userspace can now access smart battery data from sysfs instead of using the hacky `ectool`.
BUG=chromium:1047277 TEST=confirmed a /sys/class/power_supply/sbs-i2c device shows up
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I43687e63e4c1a7756c117129ced20749afc1b9e2 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/43451/3
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43451
to look at the new patch set (#4).
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
mb/google/hatch: Add smart battery I2C passthrough for Dratini
Some smart battery patches have been backported to the ChromeOS 4.19 kernel, and userspace can now access smart battery data from sysfs instead of using the hacky ectool instead.
Also change all space indents into tab indents while we're here.
BUG=chromium:1047277 TEST=confirmed a /sys/class/power_supply/sbs-i2c device shows up
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I43687e63e4c1a7756c117129ced20749afc1b9e2 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 35 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/43451/4
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43451/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43451/2/src/mainboard/google/hatch/... PS2, Line 175: chip ec/google/chromeec/i2c_tunnel
oh no, spaces in indentation!
d'oh 😞 thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 4: Code-Review+2
Patch Set 1:
Patch Set 1:
(1 comment)
Any reason to not make this change for entire hatch family?
The diagnostics team has only requested this for 4 devices, because only one OEM asks for the newly-available information in sysfs. I still have it on my list of things to do to see if we can switch from using BAT0 to just the sbs driver 😊 This allows the diagnostics team to get away from a single, very hacky use of ectool to get at the smart battery directly.
Oh okay. I still think it might be easier to have the entire family enable the same support. But, I will let you and Shelley decide.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43451/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43451/1/src/mainboard/google/hatch/... PS1, Line 175:
Use tabs instead of spaces here and in the lines below.
Done
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43451 )
Change subject: mb/google/hatch: Add smart battery I2C passthrough for Dratini ......................................................................
mb/google/hatch: Add smart battery I2C passthrough for Dratini
Some smart battery patches have been backported to the ChromeOS 4.19 kernel, and userspace can now access smart battery data from sysfs instead of using the hacky ectool instead.
Also change all space indents into tab indents while we're here.
BUG=chromium:1047277 TEST=confirmed a /sys/class/power_supply/sbs-i2c device shows up
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I43687e63e4c1a7756c117129ced20749afc1b9e2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43451 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 35 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 3f0e83b..f369949 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -28,6 +28,7 @@ select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_ESPI + select EC_GOOGLE_CHROMEEC_I2C_TUNNEL select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 2bfcc26..c5e2aeb 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -29,16 +29,16 @@
# Intel Common SoC Config #+-------------------+---------------------------+ - #| Field | Value | + #| Field | Value | #+-------------------+---------------------------+ - #| GSPI0 | cr50 TPM. Early init is | - #| | required to set up a BAR | - #| | for TPM communication | - #| | before memory is up | - #| GSPI1 | FP MCU | - #| I2C0 | Touchpad | - #| I2C1 | Touch screen | - #| I2C4 | Audio | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | FP MCU | + #| I2C0 | Touchpad | + #| I2C1 | Touch screen | + #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { @@ -47,18 +47,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 50, - .fall_time_ns = 15, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 60, - .fall_time_ns = 25, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 60, - .fall_time_ns = 60, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"
@@ -169,6 +169,25 @@ device spi 1 on end end # FPMCU end # GSPI #1 + device pci 1f.0 on + chip ec/google/chromeec + device pnp 0c09.0 on + chip ec/google/chromeec/i2c_tunnel + register "uid" = "1" + register "remote_bus" = "5" + device generic 0 on + chip drivers/i2c/generic + register "hid" = ""ACPI_DT_NAMESPACE_HID"" + register "name" = ""SBS0"" + register "uid" = "1" + register "compat_string" = ""sbs,sbs-battery"" + device i2c 0b on end + end + end + end + end + end + end # eSPI Interface device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98357A""
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Tim Wawrzynczak (Code Review)