Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31833
Change subject: console: qemu_debugcon support additional stages ......................................................................
console: qemu_debugcon support additional stages
Add support for bootblock and postcar, which were introduced on qemu in the last few month.
Fixes non working debugcon in those stages.
Change-Id: I553f12c2105237d81ae3f492ec85b17434d8334c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/include/console/qemu_debugcon.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31833/1
diff --git a/src/include/console/qemu_debugcon.h b/src/include/console/qemu_debugcon.h index 359e01a..a22c843 100644 --- a/src/include/console/qemu_debugcon.h +++ b/src/include/console/qemu_debugcon.h @@ -6,7 +6,8 @@ void qemu_debugcon_init(void); void qemu_debugcon_tx_byte(unsigned char data);
-#if CONFIG(CONSOLE_QEMU_DEBUGCON) && (ENV_ROMSTAGE || ENV_RAMSTAGE) +#if CONFIG(CONSOLE_QEMU_DEBUGCON) && \ + (ENV_ROMSTAGE || ENV_RAMSTAGE || ENV_POSTCAR || ENV_BOOTBLOCK) static inline void __qemu_debugcon_init(void) { qemu_debugcon_init(); } static inline void __qemu_debugcon_tx_byte(u8 data) {
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console: qemu_debugcon support additional stages ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31833/1/src/include/console/qemu_debugcon.h File src/include/console/qemu_debugcon.h:
https://review.coreboot.org/#/c/31833/1/src/include/console/qemu_debugcon.h@... PS1, Line 10: (ENV_ROMSTAGE || ENV_RAMSTAGE || ENV_POSTCAR || ENV_BOOTBLOCK) please, no spaces at the start of a line
Hello Kyösti Mälkki, Philipp Deppenwiese, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31833
to look at the new patch set (#2).
Change subject: console: qemu_debugcon support additional stages ......................................................................
console: qemu_debugcon support additional stages
Add support for bootblock and postcar, which were introduced on qemu in the last few month.
Fixes non working debugcon in those stages.
Change-Id: I553f12c2105237d81ae3f492ec85b17434d8334c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/emulation/qemu/Makefile.inc M src/include/console/qemu_debugcon.h 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31833/2
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console: qemu_debugcon support additional stages ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console: qemu_debugcon support additional stages ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG@7 PS2, Line 7: console: qemu_debugcon support additional stages
console/qemu_debugcon: Support additional stages
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG@12 PS2, Line 12: non working non-working
Hello Kyösti Mälkki, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31833
to look at the new patch set (#3).
Change subject: console/qemu_debugcon: Support additional stages ......................................................................
console/qemu_debugcon: Support additional stages
Add support for bootblock and postcar, which were introduced on qemu in the last few month.
Fixes non-working debugcon in those stages.
Change-Id: I553f12c2105237d81ae3f492ec85b17434d8334c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/emulation/qemu/Makefile.inc M src/include/console/qemu_debugcon.h 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31833/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console/qemu_debugcon: Support additional stages ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG@7 PS2, Line 7: console: qemu_debugcon support additional stages
console/qemu_debugcon: Support additional stages
Done
https://review.coreboot.org/#/c/31833/2//COMMIT_MSG@12 PS2, Line 12: non working
non-working
Done
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console/qemu_debugcon: Support additional stages ......................................................................
Patch Set 3: Code-Review+2
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31833 )
Change subject: console/qemu_debugcon: Support additional stages ......................................................................
console/qemu_debugcon: Support additional stages
Add support for bootblock and postcar, which were introduced on qemu in the last few month.
Fixes non-working debugcon in those stages.
Change-Id: I553f12c2105237d81ae3f492ec85b17434d8334c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31833 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/emulation/qemu/Makefile.inc M src/include/console/qemu_debugcon.h 2 files changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/drivers/emulation/qemu/Makefile.inc b/src/drivers/emulation/qemu/Makefile.inc index 3351627..d9db130 100644 --- a/src/drivers/emulation/qemu/Makefile.inc +++ b/src/drivers/emulation/qemu/Makefile.inc @@ -1,4 +1,6 @@ +bootblock-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c romstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c +postcar-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c ramstage-$(CONFIG_CONSOLE_QEMU_DEBUGCON) += qemu_debugcon.c
ramstage-$(CONFIG_DRIVERS_EMULATION_QEMU_BOCHS) += bochs.c diff --git a/src/include/console/qemu_debugcon.h b/src/include/console/qemu_debugcon.h index 359e01a..f0252ee 100644 --- a/src/include/console/qemu_debugcon.h +++ b/src/include/console/qemu_debugcon.h @@ -6,7 +6,8 @@ void qemu_debugcon_init(void); void qemu_debugcon_tx_byte(unsigned char data);
-#if CONFIG(CONSOLE_QEMU_DEBUGCON) && (ENV_ROMSTAGE || ENV_RAMSTAGE) +#if CONFIG(CONSOLE_QEMU_DEBUGCON) && \ + (ENV_ROMSTAGE || ENV_RAMSTAGE || ENV_POSTCAR || ENV_BOOTBLOCK) static inline void __qemu_debugcon_init(void) { qemu_debugcon_init(); } static inline void __qemu_debugcon_tx_byte(u8 data) {
-
Arthur Heymans (Code Review) -
build bot (Jenkins) (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)