Change in coreboot[master]: volteer/variants/eldrid: usb2_ports register tuning

[Nick Chen (Code Review)]

Nick Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: usb2_ports register tuning
......................................................................

volteer/variants/eldrid: usb2_ports register tuning

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/1

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 72571c0..b84848c 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -58,12 +58,22 @@
    		},
    	},
    }"
-	#These settings improve the USB2 Port1 eye diagram
+
+	#Disable Type-A Port A1
+	register "usb2_ports[1]" = "USB2_PORT_EMPTY"
+	
+	#Disable M.2 WWAN
+	register "usb2_ports[2]" = "USB2_PORT_EMPTY"
+
+	#improve the USB2 Port1 eye diagram
+	register "usb2_ports[3]" = "USB2_PORT_SHORT(OC_SKIP)"
+	
+	#lower camera driving
    register "usb2_ports[4]" = "{
    	.enable = 1,
-		.tx_bias = 7,
-		.tx_emp_enable = 7,
-		.pre_emp_bias = 3,
+		.tx_bias = 0,
+		.tx_emp_enable = 0,
+		.pre_emp_bias = 0,
    	.pre_emp_bit = 0,
    }"

Change in coreboot[master]: volteer/variants/eldrid: usb2 ports tuning

[Nick Chen (Code Review)]

Nick Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: usb2 ports tuning
......................................................................

volteer/variants/eldrid: usb2 ports tuning

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/2

Change in coreboot[master]: volteer/variants/eldrid: usb2 ports tuning

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: usb2 ports tuning
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47863/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47863/1/src/mainboard/google/voltee... 
PS1, Line 64: 	
trailing whitespace

https://review.coreboot.org/c/coreboot/+/47863/1/src/mainboard/google/voltee... 
PS1, Line 70: 	
trailing whitespace

Change in coreboot[master]: volteer/variants/eldrid: usb2 ports tuning

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: usb2 ports tuning
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG@7 
PS2, Line 7: volteer/variants/eldrid: usb2 ports tuning
Please make it a statement by using a verb in imperative mood.

https://chris.beams.io/posts/git-commit/

Change in coreboot[master]: volteer/variants/eldrid: usb2 ports tuning

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: usb2 ports tuning
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
PS2, Line 64: 	
extra tab

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
PS2, Line 70: 	
extra tab

Change in coreboot[master]: volteer/variants/eldrid: redefine usb2 ports register

[Nick Chen (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47863

to look at the new patch set (#3).

Change subject: volteer/variants/eldrid: redefine usb2 ports register
......................................................................

volteer/variants/eldrid: redefine usb2 ports register

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/3

Change in coreboot[master]: volteer/variants/eldrid: redefine usb2 ports register

[Nick Chen (Code Review)]

Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: redefine usb2 ports register
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47863/2//COMMIT_MSG@7 
PS2, Line 7: volteer/variants/eldrid: usb2 ports tuning
> Please make it a statement by using a verb in imperative mood. […]

Done

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
PS2, Line 64:
> extra tab

Done

https://review.coreboot.org/c/coreboot/+/47863/2/src/mainboard/google/voltee... 
PS2, Line 70:
> extra tab

Done

Change in coreboot[master]: volteer/variants/eldrid: redefine usb2 ports register

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: volteer/variants/eldrid: redefine usb2 ports register
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47863/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47863/3//COMMIT_MSG@7 
PS3, Line 7: volteer/variants/eldrid: redefine usb2 ports register
suggestion:
mb/google/volteer: Update Eldrid USB2 port settings in devicetree

Change in coreboot[master]: volteer/variants/eldrid: Update Eldrid USB2 port settings in override...

[Nick Chen (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47863

to look at the new patch set (#4).

Change subject: volteer/variants/eldrid: Update Eldrid USB2 port settings in overridetree
......................................................................

volteer/variants/eldrid: Update Eldrid USB2 port settings in overridetree

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/4

Change in coreboot[master]: mb/google/volteer: Update Eldrid USB2 port settings in overridetree

[Nick Chen (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47863

to look at the new patch set (#5).

Change subject: mb/google/volteer: Update Eldrid USB2 port settings in overridetree
......................................................................

mb/google/volteer: Update Eldrid USB2 port settings in overridetree

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47863/5

Change in coreboot[master]: mb/google/volteer: Update Eldrid USB2 port settings in overridetree

[Nick Chen (Code Review)]

Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: mb/google/volteer: Update Eldrid USB2 port settings in overridetree
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47863/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47863/3//COMMIT_MSG@7 
PS3, Line 7: volteer/variants/eldrid: redefine usb2 ports register
> suggestion: […]

Done

Change in coreboot[master]: mb/google/volteer: Update Eldrid USB2 port settings in overridetree

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: mb/google/volteer: Update Eldrid USB2 port settings in overridetree
......................................................................

mb/google/volteer: Update Eldrid USB2 port settings in overridetree

1. Disable M.2 WWAN and Type-A Port A1
2. Change register 4 to 3 and tuning USB2 Port1 eye diagram
3. Lower camera driving

BUG=b:169105751
Signed-off-by: Nick Chen 
Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47863
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 72571c0..51bc991 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -58,12 +58,22 @@
    		},
    	},
    }"
-	#These settings improve the USB2 Port1 eye diagram
+
+	#Disable Type-A Port A1
+	register "usb2_ports[1]" = "USB2_PORT_EMPTY"
+
+	#Disable M.2 WWAN
+	register "usb2_ports[2]" = "USB2_PORT_EMPTY"
+
+	#improve the USB2 Port1 eye diagram
+	register "usb2_ports[3]" = "USB2_PORT_SHORT(OC_SKIP)"
+
+	#lower camera driving
    register "usb2_ports[4]" = "{
    	.enable = 1,
-		.tx_bias = 7,
-		.tx_emp_enable = 7,
-		.pre_emp_bias = 3,
+		.tx_bias = 0,
+		.tx_emp_enable = 0,
+		.pre_emp_bias = 0,
    	.pre_emp_bit = 0,
    }"

Change in coreboot[master]: mb/google/volteer: Update Eldrid USB2 port settings in overridetree

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47863 )

Change subject: mb/google/volteer: Update Eldrid USB2 port settings in overridetree
......................................................................

Patch Set 6: Code-Review+2