Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45911 )
Change subject: drivers/i2c: Add chip driver for GPIO based I2C multiplexer ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45911/6/src/drivers/i2c/gpiomux/mux... File src/drivers/i2c/gpiomux/mux/mux.c:
https://review.coreboot.org/c/coreboot/+/45911/6/src/drivers/i2c/gpiomux/mux... PS6, Line 37: "_HID", ACPI_DT_NAMESPACE_HID)
Wait but if you do this and use PRP0001, aren't you deferring into the DT world entirely, including […]
Would this be applicable: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/DSD-properties-ru...
"It often is useful to make _DSD return property sets that follow Device Tree bindings.
In those cases, however, the above validity considerations must be taken into account in the first place and returning invalid property sets from _DSD must be avoided. For this reason, it may not be possible to make _DSD return a property set following the given DT binding literally and completely. Still, for the sake of code re-use, it may make sense to provide as much of the configuration data as possible in the form of device properties and complement that with an ACPI-specific mechanism suitable for the use case at hand."
In my opinion, this should apply for the i2c-parent property. Even though it is a required option for dt-bindings, ACPI has a different way of defining relation between devices and so i2c-parent property can be skipped in case of ACPI.
It also saves us having to allocate another ACPI ID just for this case.
-
Furquan Shaikh (Code Review)