HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )
Change subject: src/cpu/intel: Set get_ia32_fsb function common ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c File src/cpu/intel/common/fsb.c:
https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@54 PS2, Line 54: 0x4
Do you want to add names here too ?
I think it is not useful to add "Netburst Model 4" here. (same for the other cases)
https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c File src/cpu/x86/lapic/apic_timer.c:
https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c@46 PS2, Line 46: static int set_timer_fsb(void) : { : car_set_var(g_timer_fsb, get_ia32_fsb()); : return 0;
return value must depend on whether g_timer_fsb is sane.
thank you so much for the review. I'll remove "return 0".
https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h File src/include/cpu/intel/fsb.h:
https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h@17 PS2, Line 17: get_ia32_fsb(void)
Add description. […]
Ok, I'll do. thank you so much for the review
-
HAOUAS Elyes (Code Review)