Attention is currently required from: Kapil Porwal, Michał Żygowski, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80562?usp=email )
Change subject: soc/intel/alderlake/acpi: Drop ACPI stub for SATA device
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Seems like I should drop SATA here CB:80561 ?
assuming JSL select SOC_INTEL_COMMON_BLOCK_SATA then yes. Any of these PCI-attached devices which may or may not be present/enabled should really have the ACPI generated at runtime so we don't have ACPI devices present/enabled when the actual device is not
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80562?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic45a059f47a090aa1993e83884408a82826b30cf
Gerrit-Change-Number: 80562
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 16 Feb 2024 16:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment