Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Elyes Haouas, Felix Singer, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, TangYiwei, niehaitao@bytedance.com.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email )
Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/bytedance/bd_egs/Kconfig:
https://review.coreboot.org/c/coreboot/+/75722/comment/91fb1abd_1159813d :
PS10, Line 32: default "\_SB.C%03d"
Let me confirm this part with other people and get back here, on what is the best value to put it in […]
is there any acpi bytecode that gets emitted by the fsp that references the cpu object or are all references to these cpu object only in the corbeoot source? if there are only references to those cpu object from the coreboot side, there's no need to change the defaults from the soc code; also since this is sort-of soc dependent, it probably shouldn't be overridden on the mainboard level. if the fsp generates some acpi bytecode that references those, i'd also guess that the same fsp is used for all mainboards, so i also doubt that this should be overridden on the mainboard level in this case.
the cpu object names just need to be unique for each cpu and the acpi interpreter doesn't care if decimal or hex digits are used in the cpu object names; the main advantage of using hex digits is that that that allows more unique cpu acpi objects
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75722?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d
Gerrit-Change-Number: 75722
Gerrit-PatchSet: 12
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: niehaitao@bytedance.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: laykong
lay.kong@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: niehaitao@bytedance.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 22 Jun 2023 16:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment