Attention is currently required from: Anil Kumar K.
Felix Held has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
PS11:
while i'm all for avoiding duplicate code, i don't like this approach too much, since when adding the drivers_soundwire_alc711 chip in the devicetree, the actual behavior will depend on which kconfig option is selected and those two options will also more or less be mutually exclusive, so its not possible to have both in a system using one firmware image; not even as different codec options where only one will be present on the board
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 11
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No