Attention is currently required from: Eric Lai, Julius Werner, Martin L Roth.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75835?usp=email )
Change subject: lib/fw_config: Make fw_config_is_provisioned() always available
......................................................................
Patch Set 2:
(1 comment)
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/75835/comment/f691187d_d9631ce8 :
PS1, Line 100: return fw_config_get() != UNDEFINED_FW_CONFIG;
FW config may not provision in SMT. We need this check I think. […]
OK, so I moved `fw_config_is_provisioned()` implementation to the header file. `fw_config_get()` has weak implementation in the `src/lib/coreboot_table.c`, so it will always be available.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75835?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ea21b19339cd93ba78dbe25213cbfb40e012937
Gerrit-Change-Number: 75835
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 08:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment