Attention is currently required from: Tarun Tuli, Subrata Banik.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74727 )
Change subject: mb/google/brya/vat/taeko:Disable C1E for RPL CPU ......................................................................
Patch Set 1:
(7 comments)
File src/mainboard/google/brya/variants/taeko/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/de7ef190_440b0e20 PS1, Line 15: // Disable C1E for Tabor code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/4a5a0e1f_c83f6153 PS1, Line 16: if (fw_config_probe(FW_CONFIG(RPL, IS_RPL))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/aeafc72d_f1beff47 PS1, Line 16: if (fw_config_probe(FW_CONFIG(RPL, IS_RPL))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/fe1fc63f_51218d39 PS1, Line 16: if (fw_config_probe(FW_CONFIG(RPL, IS_RPL))) { suspect code indent for conditional statements (8, 24)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/d40e4f19_cd530942 PS1, Line 19: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/00a44427_84ffa6aa PS1, Line 19: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174886): https://review.coreboot.org/c/coreboot/+/74727/comment/f713c012_6e33039c PS1, Line 20: else if (fw_config_probe(FW_CONFIG(RPL, NOT_RPL))){ space required before the open brace '{'
-
build bot (Jenkins) (Code Review)