Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30930
Change subject: drivers/intel/fsp2_0: Set basename for FSP binaries ......................................................................
drivers/intel/fsp2_0: Set basename for FSP binaries
Since there is no standardized naming scheme for the FSP binaries, the option USE_FSP_REPO can't be used on some platforms, because the output filenames differ and the build process awaits "Fsp_*.fd" as filename.
As a workaround, add the option -n to SplitFspBin.py, which defines the basename.
Change-Id: Idc684ad00033ffafd1090fc32b23549ce9603b4f Signed-off-by: Felix Singer migy@darmstadt.ccc.de --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30930/1
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index 79fe5f8..1d1bae7 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -69,7 +69,7 @@
ifeq ($(CONFIG_FSP_USE_REPO),y) $(obj)/Fsp_M.fd: $(call strip_quotes,$(CONFIG_FSP_FD_PATH)) - python2 3rdparty/fsp/Tools/SplitFspBin.py split -f $(CONFIG_FSP_FD_PATH) -o "$(obj)" + python2 3rdparty/fsp/Tools/SplitFspBin.py split -f $(CONFIG_FSP_FD_PATH) -o "$(obj)" -n "Fsp.fd"
$(obj)/Fsp_S.fd: $(call strip_quotes,$(CONFIG_FSP_FD_PATH)) $(obj)/Fsp_M.fd true
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30930
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0: Set basename for FSP binaries ......................................................................
drivers/intel/fsp2_0: Set basename for FSP binaries
Since there is no standardized naming scheme for the FSP binaries, the option USE_FSP_REPO can't be used on some platforms, because some of the filenames differ and the build process awaits "Fsp_*.fd" as filename.
As a workaround, add the option -n to SplitFspBin.py, which defines the basename.
Change-Id: Idc684ad00033ffafd1090fc32b23549ce9603b4f Signed-off-by: Felix Singer migy@darmstadt.ccc.de --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30930/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30930 )
Change subject: drivers/intel/fsp2_0: Set basename for FSP binaries ......................................................................
Patch Set 4: Code-Review+2
Hello Naresh Solanki, Aaron Durbin, Patrick Rudolph, Nathaniel L Desimone, Subrata Banik, Balaji Manigandan, Rizwan Qureshi, build bot (Jenkins), Hannah Williams, Patrick Georgi, Pratikkumar V Prajapati, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30930
to look at the new patch set (#5).
Change subject: drivers/intel/fsp2_0: Set basename for FSP binaries ......................................................................
drivers/intel/fsp2_0: Set basename for FSP binaries
Since there is no standardized naming scheme for the FSP binaries, the option USE_FSP_REPO can't be used on some platforms, because some of the filenames differ and the build process awaits "Fsp_*.fd" as filename.
As a workaround, add the option -n to SplitFspBin.py, which defines the basename.
Change-Id: Idc684ad00033ffafd1090fc32b23549ce9603b4f Signed-off-by: Felix Singer migy@darmstadt.ccc.de --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30930/5
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30930 )
Change subject: drivers/intel/fsp2_0: Set basename for FSP binaries ......................................................................
drivers/intel/fsp2_0: Set basename for FSP binaries
Since there is no standardized naming scheme for the FSP binaries, the option USE_FSP_REPO can't be used on some platforms, because some of the filenames differ and the build process awaits "Fsp_*.fd" as filename.
As a workaround, add the option -n to SplitFspBin.py, which defines the basename.
Change-Id: Idc684ad00033ffafd1090fc32b23549ce9603b4f Signed-off-by: Felix Singer migy@darmstadt.ccc.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/30930 Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index f26a776..d627a3d 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -69,7 +69,7 @@
ifeq ($(CONFIG_FSP_USE_REPO),y) $(obj)/Fsp_M.fd: $(call strip_quotes,$(CONFIG_FSP_FD_PATH)) - python2 3rdparty/fsp/Tools/SplitFspBin.py split -f $(CONFIG_FSP_FD_PATH) -o "$(obj)" + python2 3rdparty/fsp/Tools/SplitFspBin.py split -f $(CONFIG_FSP_FD_PATH) -o "$(obj)" -n "Fsp.fd"
$(obj)/Fsp_S.fd: $(call strip_quotes,$(CONFIG_FSP_FD_PATH)) $(obj)/Fsp_M.fd true
-
Felix Singer (Code Review) -
Martin Roth (Code Review)
-
Subrata Banik (Code Review)