Attention is currently required from: Julius Werner, Jérémy Compostella, Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83574?usp=email )
Change subject: Makefile.mk: Add a common link_stage function and use it
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83574/comment/503c18d5_29471b5b?usp... :
PS2, Line 16: - the x86 --oformat is dropped as it is not needed.
So we'd have to duplicate that file for x86?
Hmmm, looking through Makefiles, couldn't we just do something like
LDFLAGS_x86_32 += --oformat elf-i386
LDFLAGS_x86_64 += --oformat elf-x86-64
?
`toolchain.mk` should add that to the respective stages (all on x86, I guess).
Added the linker script equivalents to remove this compiler argument.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f7686894c99732d06972e7ba327061db6d7c44
Gerrit-Change-Number: 83574
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 20 Aug 2024 21:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz